lkml.org 
[lkml]   [2018]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Input: uinput - add a schedule point in uinput_inject_events()
On Thu, Oct 04, 2018 at 05:54:32PM -0700, Dmitry Torokhov wrote:
> Large writes to uinput interface may cause rcu stalls. Let's add
> cond_resched() to the loop to avoid this.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Reviewed-by: Paul E. McKenney <paulmck@linux.ibm.com>

> ---
> drivers/input/misc/uinput.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/misc/uinput.c b/drivers/input/misc/uinput.c
> index eb14ddf69346..8ec483e8688b 100644
> --- a/drivers/input/misc/uinput.c
> +++ b/drivers/input/misc/uinput.c
> @@ -598,6 +598,7 @@ static ssize_t uinput_inject_events(struct uinput_device *udev,
>
> input_event(udev->dev, ev.type, ev.code, ev.value);
> bytes += input_event_size();
> + cond_resched();
> }
>
> return bytes;
> --
> 2.19.0.605.g01d371f741-goog
>
>
> --
> Dmitry
>

\
 
 \ /
  Last update: 2018-10-05 06:11    [W:0.075 / U:0.712 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site