Messages in this thread |  | | Date | Thu, 4 Oct 2018 16:57:32 +0200 | From | Daniel Lezcano <> | Subject | Re: [PATCH 4/6] cpuidle: menu: Do not update last_state_idx in menu_select() |
| |
On Tue, Oct 02, 2018 at 11:45:07PM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > It is not necessary to update data->last_state_idx in menu_select() > as it only is used in menu_update() which only runs when > data->needs_update is set and that is set only when updating > data->last_state_idx in menu_reflect(). > > Accordingly, drop the update of data->last_state_idx from > menu_select() and get rid of the (now redundant) "out" label > from it. > > No intentional behavior changes. > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > ---
Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
|  |