[lkml]   [2018]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] net: arp, ipv6: handle special case of tap device
Vladis Dronov <> writes:

>> From: "David Miller" <>
>> Sent: Wednesday, October 3, 2018 7:25:40 AM
>> > Probably, this functionality is already used by some userspace, so I
>> > believe, I cannot just remove TUNSETLINK ioctl.
>> Who uses it, how do they use it, and what do they sanely expect about
>> the link layer header properties of a tap device which has had ->type
>> changed?
> Honestly, I have no idea. I was working on a syzkaller bug report and
> found that the reason for that bug was TUNSETLINK ioctl.
> This ioctl was introduced 13 years ago with ff4cc3ac93e1d and it says:
>> For use with
>> wireless and other networking types it should be possible to set the
>> ARP type via an ioctl.
> , that's all. Let me try to prepare a patch that sets dev->addr_len and
> dev->broadcast according to dev->type. I would probably need an advise
> what other fields must be adjusted too.
> Otherwise, we can just to remove the TUNSETLINK ioctl.

Let's add linux-wireless in case someone there knows about the ioctl.

Kalle Valo

 \ /
  Last update: 2018-10-04 11:55    [W:0.054 / U:0.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site