Messages in this thread |  | | Subject | Re: [RFC PATCH v3 1/7] book3s/64: avoid circular header inclusion in mmu-hash.h | From | "Aneesh Kumar K.V" <> | Date | Thu, 4 Oct 2018 13:53:08 +0530 |
| |
On 10/4/18 1:50 PM, Christophe LEROY wrote: > > > Le 03/10/2018 à 06:24, Nicholas Piggin a écrit : >> On Mon, 1 Oct 2018 12:30:19 +0000 (UTC) >> Christophe Leroy <christophe.leroy@c-s.fr> wrote: >> >>> When activating CONFIG_THREAD_INFO_IN_TASK, linux/sched.h >>> includes asm/current.h. This generates a circular dependency. >>> To avoid that, asm/processor.h shall not be included in mmu-hash.h >>> >>> In order to do that, this patch moves into a new header called >>> asm/task_size.h the information from asm/processor.h requires by >>> mmu-hash.h >> >> Doesn't look like you use this header in 32-bit code. Put task_size.h >> in asm/64/ maybe? > > There is no asm/64/ dir at the time being, only book3s/64/ and nohash/64/ > > I'm thinking about leaving it in asm/ but renaming it task_size_user64.h >
Quiet a lot of that is book3s 64 specifi because we have there.
#if defined(CONFIG_PPC_BOOK3S_64) && defined(CONFIG_PPC_64K_PAGES) /* * Max value currently used: */
-aneesh
|  |