[lkml]   [2018]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [alsa-devel] [PATCH linux-next v2 9/9] ASoC: rsnd: add busif property to dai stream

Hi Jiada

Thank you for your feedback

> >> in GEN3 SSI may use different BUSIF for data transfer,
> >> this patch adds busif property to each dai stream,
> >> to indicate the BUSIF used by playback/capture stream.
> >>
> >> Also adds rsnd_ssi_select_busif() to automatically select
> >> BUSIF (currently only BUSIF0 is selected)
> >>
> >> Signed-off-by: Jiada Wang <>
> >> ---
> > And this patch selects it on runtime (= hw_param) ?
> Because, in order to automatically determine BUSIF number,
> information like SSI mode (non-Split/Split/Ex-Split), runtime channel,
> are required
> (in our internal implementation, SSI mode is selected by kctrl)
> because of this, in this patch, BUSIF is selected on runtime
> > But, I think we can/should select it on probe timing from DT connection.
> > Am I misunderstanding ?
> with the above reasoning, BUSIF is selected on runtime.
> what do you think?

I have no objection that you are customizing your kernel locally.
But, upstreaming kernel based on it is not acceptable for me.
I'm not sure detail of your local implementation, but I don't think we
need to select SSI mode by kctrl.
If my understanding was correct, it can also be selected automatically somehow.
Or, am I misunderstanding ?

I could understand what you want to do, and yes, I can agree that we want/need
to have it on upstream. Thank you very much to indicating it to me.
But we need to consider more how to implement it.
Especially, it is related to DT bindings.
As you already know, if it is implemented on upstream kernel, we need to keep
compatibility in the future, and it is very difficult.

So, my opinions for BUSIFn support are
- SSI mode should be selected automatically
- BUSIFn connection should be selected on DT
(I think we don't want random sound output position ?)
- To select it, we need to have new "ssiu" DT seetings,
or parse sound card. Maybe adding ssiu is realistic.

Best regards
Kuninori Morimoto

 \ /
  Last update: 2018-10-04 05:45    [W:0.084 / U:21.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site