lkml.org 
[lkml]   [2018]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3] staging: vboxvideo: Remove unnecessary parentheses
From
Date
Hi,

On 31-10-18 16:03, Shayenne da Luz Moura wrote:
> Remove unneeded parentheses around the arguments of ||. This reduces
> clutter and code behave in the same way.
> Change suggested by checkpatch.pl.
>
> vbox_main.c:119: CHECK: Unnecessary parentheses around 'rects[i].x2 <
> crtc->x'
>
> Signed-off-by: Shayenne da Luz Moura <shayenneluzmoura@gmail.com>

Thank you.

Still looks good to me:

Acked-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans



> ---
> Changes in v2:
> - Make the commit message more clearer.
>
> Changes in v3:
> - Update to apply patch to the latest kernel tree
>
> drivers/staging/vboxvideo/vbox_main.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vboxvideo/vbox_main.c b/drivers/staging/vboxvideo/vbox_main.c
> index 7466c1103ff6..ad0e0b62bd1e 100644
> --- a/drivers/staging/vboxvideo/vbox_main.c
> +++ b/drivers/staging/vboxvideo/vbox_main.c
> @@ -122,10 +122,10 @@ void vbox_framebuffer_dirty_rectangles(struct drm_framebuffer *fb,
> struct vbva_cmd_hdr cmd_hdr;
> unsigned int crtc_id = to_vbox_crtc(crtc)->crtc_id;
>
> - if ((rects[i].x1 > crtc_x + mode->hdisplay) ||
> - (rects[i].y1 > crtc_y + mode->vdisplay) ||
> - (rects[i].x2 < crtc_x) ||
> - (rects[i].y2 < crtc_y))
> + if (rects[i].x1 > crtc_x + mode->hdisplay ||
> + rects[i].y1 > crtc_y + mode->vdisplay ||
> + rects[i].x2 < crtc_x ||
> + rects[i].y2 < crtc_y)
> continue;
>
> cmd_hdr.x = (s16)rects[i].x1;
>

\
 
 \ /
  Last update: 2018-10-31 16:32    [W:0.030 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site