lkml.org 
[lkml]   [2018]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 04/16] blk-mq: pass in request/bio flags to queue mapping
From
Date
On 10/30/18 6:37 PM, Sagi Grimberg wrote:
>
>> static inline struct blk_mq_hw_ctx *blk_mq_map_queue(struct request_queue *q,
>> + unsigned int flags,
>> unsigned int cpu)
>> {
>> struct blk_mq_tag_set *set = q->tag_set;
>> @@ -84,7 +85,7 @@ static inline struct blk_mq_hw_ctx *blk_mq_map_queue_type(struct request_queue *
>> unsigned int hctx_type,
>> unsigned int cpu)
>> {
>> - return blk_mq_map_queue(q, cpu);
>> + return blk_mq_map_queue(q, hctx_type, cpu);
>> }
>
> Haven't read through the rest of the patch set, but it looks a bit
> strange that a type enumeration is being passed on as flags field.

It's impossible to get it 100% right at this point, which is why
it looks a bit odd. If you read on, it'll make sense.

--
Jens Axboe

\
 
 \ /
  Last update: 2018-10-31 15:18    [W:0.056 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site