[lkml]   [2018]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] gpio: pl061: Move irq_chip definition inside struct pl061
On Wed, Oct 24, 2018 at 7:29 PM Manivannan Sadhasivam
<> wrote:

> Keeping the irq_chip definition static will make it shared with multiple
> giochips in the system. This practice is considered to be bad and now we
> will get the below warning from gpiolib core:
> "detected irqchip that is shared with multiple gpiochips: please fix the
> driver."
> Hence, move the irq_chip definition from static to `struct pl061` for
> using a unique irq_chip for each gpiochip.
> Signed-off-by: Manivannan Sadhasivam <>

Patch applied. Much better like this!

Linus Walleij

 \ /
  Last update: 2018-10-31 11:35    [W:0.031 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site