lkml.org 
[lkml]   [2018]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: scsi_set_medium_removal timeout issue
Date
Hi:

>-----Original Message-----
>From: Oliver Neukum [mailto:oneukum@suse.com]
>Sent: Tuesday, October 30, 2018 4:56 PM
>To: Zengtao (B) <prime.zeng@hisilicon.com>; jejb@linux.vnet.ibm.com;
>gregkh@linuxfoundation.org; martin.petersen@oracle.com;
>stern@rowland.harvard.edu
>Cc: usb-storage@lists.one-eyed-alien.net; linux-kernel@vger.kernel.org;
>linux-scsi@vger.kernel.org; linux-usb@vger.kernel.org
>Subject: Re: scsi_set_medium_removal timeout issue
>
>On Di, 2018-10-30 at 08:28 +0000, Zengtao (B) wrote:
>> Hi
>
>> For the issue itself, there is my observation:
>> In the step 4, the Host will issue an
>PREVENT_ALLOW_MEDIUM_REMOVAL scsi command.
>> and and timeout happens due to the device 's very slow
>fsg_lun_fsync_sub.
>> I found there are two methods to workaround the issue:
>> 1. Change the timeout value of host scsi command
>> PREVENT_ALLOW_MEDIUM_REMOVAL to to about 60 seconds from 10
>seconds.
>
>That is near useless, because the gadget can be used with other systems.
>

Is it reasonable to keep the current value? Or can we change it to cover
as much systems as possible.

>> 2. Remove the fsg_lun_fsync_sub in the device's Mass storage gadget
>driver.
>
>It exists for a reason. The blocks have to be on the medium.
>It seems to me that your gadget just allows too many dirty pages in the
>cache.
>
> Regards
> Oliver

Regards
Zengtao

\
 
 \ /
  Last update: 2018-10-30 10:25    [W:0.085 / U:1.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site