[lkml]   [2018]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] ALSA: intel8x0: Fix fall-through annotations

On 10/3/18 8:34 PM, Takashi Iwai wrote:
>> You are correct. It does not trigger a warning.
>> There are about 50 similar instances in the whole codebase. And, as they
>> are just a few, what I'm trying to do is to replace them with the most
>> commonly used form: "fall through"
> Hm, then I'm not sure whether it's worth for further similar
> replacements. A term "fallthru" is also very commonly used, and the
> compiler knows it, too, so why bother to rewrite?

Not that common actually. There are more than 2000 instances of "fall through"
and just ~50 of "fallthru" and ~40 of "fall thru"

> I don't mean to revert the already applied changes, but maybe better
> to concentrate on fixing other real bugs (and/or real warnings).

Yeah. Sure thing. It's just that I sort of ran into those cases a few days ago.


 \ /
  Last update: 2018-10-03 20:42    [W:0.029 / U:2.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site