lkml.org 
[lkml]   [2018]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v8 05/10] dt-bindings: i3c: Add macros to help fill I3C/I2C device's reg property
From
Date
On Wed, 2018-10-03 at 15:22 +0200, Boris Brezillon wrote:
> The reg property of devices connected to an I3C bus have 3 cells, and
> filling them manually is not trivial. Provides macros to help doing
> that.

This patch logic seems excessively fragile.

> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
> Changes in v8:
> - None
>
> Changes in v5:
> - none
> ---
> include/dt-bindings/i3c/i3c.h | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
> create mode 100644 include/dt-bindings/i3c/i3c.h
>
> diff --git a/include/dt-bindings/i3c/i3c.h b/include/dt-bindings/i3c/i3c.h
> new file mode 100644
> index 000000000000..97448c546649
> --- /dev/null
> +++ b/include/dt-bindings/i3c/i3c.h
> @@ -0,0 +1,28 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (C) 2017 Cadence Design Systems Inc.
> + *
> + * Author: Boris Brezillon <boris.brezillon@bootlin.com>
> + */
> +
> +#ifndef _DT_BINDINGS_I3C_I3C_H
> +#define _DT_BINDINGS_I3C_I3C_H
> +
> +#define IS_I2C_DEV 0x80000000
> +
> +#define I2C_DEV(addr, lvr) \
> + (addr) (IS_I2C_DEV | (lvr)) 0x0

This looks to be missing surrounding parentheses.

> +
> +#define I3C_PID(manufid, partid, instid, extrainfo) \
> + ((manufid) << 1) \
> + (((partid) << 16) | ((instid) << 12) | (extrainfo))

This macro doesn't make any sense. Missing a shift and an or?

> +
> +#define I3C_DEV_WITH_STATIC_ADDR(addr, manufid, partid, \
> + instid, extrainfo) \
> + (addr) I3C_PID(manufid, partid, instid, extrainfo)
> +
> +#define I3C_DEV(manufid, partid, instid, extrainfo) \
> + I3C_DEV_WITH_STATIC_ADDR(0x0, manufid, partid, \
> + instid, extrainfo)
> +
> +#endif

\
 
 \ /
  Last update: 2018-10-03 20:38    [W:0.140 / U:0.824 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site