Messages in this thread |  | | From | Doug Anderson <> | Date | Wed, 3 Oct 2018 10:45:02 -0700 | Subject | Re: [PATCH] soc: qcom: Add irq clear handling during SE init |
| |
Hi,
On Wed, Oct 3, 2018 at 5:24 AM Alok Chauhan <alokc@codeaurora.org> wrote: > > when the kernel inits a SE, its quite possible we have pending interrupts > from bootloaders which did not handle/clear them. So do this in kernel at > the SE init, to avoid some of it causing bad behavior, while at it also > club all the register writes needed to clear the se irqs into a function > to avoid repeating it over. > > Signed-off-by: Alok Chauhan <alokc@codeaurora.org> > --- > drivers/soc/qcom/qcom-geni-se.c | 25 +++++++++++++------------ > 1 file changed, 13 insertions(+), 12 deletions(-)
This looks fine to me. To clarify this doesn't fix any known issues and it just fixes the theoretical case where somehow a IRQ was sitting around (maybe left by the firmware) so we want to make really certain that we start with a clean state at init time.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
|  |