Messages in this thread |  | | Subject | Re: [PATCH] drm/imx: move 'legacyfb_depth' definition out of #ifdef | From | Noralf Trønnes <> | Date | Wed, 3 Oct 2018 17:49:32 +0200 |
| |
Den 02.10.2018 22.58, skrev Arnd Bergmann: > The variable is now referenced unconditionally, but still > declared in an #ifdef: > > drivers/gpu/drm/imx/imx-drm-core.c: In function 'imx_drm_bind': > drivers/gpu/drm/imx/imx-drm-core.c:264:6: error: 'legacyfb_depth' undeclared (first use in this function); did you mean 'lockdep_depth'? > > Remove the #ifdef so it can always be accessed. > > Fixes: f53705fd9803 ("drm/imx: Use drm_fbdev_generic_setup()") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > ---
I've already applied the previous one you sent: https://cgit.freedesktop.org/drm/drm-misc/commit/?id=064b06bbf117f8b5e64a5143e970d5a1cf602fd6
Not sure when it reaches linux-next now that we are past rc6.
Noralf.
> drivers/gpu/drm/imx/imx-drm-core.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c > index a70f3131a377..0e6942f21a4e 100644 > --- a/drivers/gpu/drm/imx/imx-drm-core.c > +++ b/drivers/gpu/drm/imx/imx-drm-core.c > @@ -35,10 +35,8 @@ > > #define MAX_CRTC 4 > > -#if IS_ENABLED(CONFIG_DRM_FBDEV_EMULATION) > static int legacyfb_depth = 16; > module_param(legacyfb_depth, int, 0444); > -#endif > > DEFINE_DRM_GEM_CMA_FOPS(imx_drm_driver_fops); >
|  |