lkml.org 
[lkml]   [2018]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] spi: slave: Fix missing break in switch
From
Date
Hi,

On 10/3/18 5:01 PM, Mark Brown wrote:
> On Wed, Oct 03, 2018 at 04:46:45PM +0200, Geert Uytterhoeven wrote:
>> On Wed, Oct 3, 2018 at 2:57 PM Gustavo A. R. Silva
>
>>> case CMD_REBOOT:
>>> dev_info(&priv->spi->dev, "Rebooting system...\n");
>>> kernel_restart(NULL);
>>> + break;
>
>> Alternatively, kernel_restart() and friends could be marked __noreturn.
>
> Yes, that seems more sensible though there's no harm in this patch even
> with that. It'd definitely avoid other issues in future.
>

I'll include the __noreturn in addition to the break statement.
I'll send v2 shortly.

Thank you both for the feedback.
--
Gustavo

\
 
 \ /
  Last update: 2018-10-03 17:06    [W:0.081 / U:18.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site