lkml.org 
[lkml]   [2018]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] spi: slave: Fix missing break in switch
On Wed, Oct 03, 2018 at 04:46:45PM +0200, Geert Uytterhoeven wrote:
> On Wed, Oct 3, 2018 at 2:57 PM Gustavo A. R. Silva

> > case CMD_REBOOT:
> > dev_info(&priv->spi->dev, "Rebooting system...\n");
> > kernel_restart(NULL);
> > + break;

> Alternatively, kernel_restart() and friends could be marked __noreturn.

Yes, that seems more sensible though there's no harm in this patch even
with that. It'd definitely avoid other issues in future.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-10-03 17:02    [W:0.035 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site