[lkml]   [2018]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] kvm: nVMX: fix entry with pending interrupt if APICv is enabled
On 03/10/2018 16:53, Sean Christopherson wrote:
> Isn't enable_apicv redundant with kvm_vcpu_apicv_active()? And since
> getting RVI requires a VMREAD, I think it would make sense to only
> fall into this code if !evaluate_pending_interrupts, e.g.:
> if (!evaluate_pending_interrupts && kvm_vcpu_apicv_active(vcpu))
> evaluate_pending_interrupts |= vmx_get_rvi() > 0;

Yes, both suggestions make sense. I'll make it

Thanks to both you and Nikita for the quick review!


 \ /
  Last update: 2018-10-03 16:55    [W:0.034 / U:4.904 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site