[lkml]   [2018]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [QUEUED v20180920 04/16] stm class: Introduce framing protocol drivers
Mathieu Poirier <> writes:

>> + err = stm_lookup_protocol(proto, &pdrv, &pdrv_node_type);
>> kfree(devname);
>> - if (!stm)
>> + if (err) {
>> + stm_put_device(stm);
>> return ERR_PTR(-ENODEV);
>> + }
> This condition prevent the subsystem from being used until patch 06/16 is added.

Good catch, I completely missed that.

> I would also suggest automatically compiling in the functionality provided by
> p_basic if p_sys-t is not selected.

That's kind of the intention; in Kconfig the PROTO_BASIC should default
to the same thing as CONFIG_STM, so it should be present unless the user
specifically interfered and disabled it.

> That way we preserve the original
> behaviour. I would also use p_basic if no protocol driver is selected rather
> than leaving it to the insertion order to make things more
> deterministic.

Agreed, more deterministic is good.


 \ /
  Last update: 2018-10-03 15:04    [W:0.070 / U:3.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site