Messages in this thread |  | | From | Kalle Valo <> | Subject | Re: [PATCH 3/3] iwlwifi: Load firmware exclusively for Intel WiFi | Date | Wed, 03 Oct 2018 11:58:12 +0300 |
| |
Luciano Coelho <luciano.coelho@intel.com> writes:
>> +#if IS_ENABLED(CONFIG_BT_INTEL) >> + if (firmware_unlock_func) { >> + firmware_unlock_func(); >> + symbol_put(btintel_firmware_lock); >> + firmware_lock_func = NULL; >> + symbol_put(btintel_firmware_unlock); >> + firmware_unlock_func = NULL; >> + } >> +#endif >> + } >> else >> ret = iwl_pcie_load_given_ucode(trans, fw); >> > > I'm not sure I like adding this BT-specific stuff here, especially not > without a detailed explanation.
This looks like an ugly hack and the commit log tells nothing. This really needs strong justifications to even consider doing something like this.
-- Kalle Valo
|  |