Messages in this thread |  | | Date | Tue, 02 Oct 2018 22:31:36 -0700 (PDT) | Subject | Re: [PATCH] cxgb4: Use proper enum in cxgb4_dcb_handle_fw_update | From | David Miller <> |
| |
From: Nathan Chancellor <natechancellor@gmail.com> Date: Sun, 30 Sep 2018 20:51:43 -0700
> Clang warns when one enumerated type is implicitly converted to another. > > drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c:303:7: warning: implicit > conversion from enumeration type 'enum cxgb4_dcb_state' to different > enumeration type 'enum cxgb4_dcb_state_input' [-Wenum-conversion] > ? CXGB4_DCB_STATE_FW_ALLSYNCED > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c:304:7: warning: implicit > conversion from enumeration type 'enum cxgb4_dcb_state' to different > enumeration type 'enum cxgb4_dcb_state_input' [-Wenum-conversion] > : CXGB4_DCB_STATE_FW_INCOMPLETE); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 2 warnings generated. > > Use the equivalent value of the expected type to silence Clang while > resulting in no functional change. > > CXGB4_DCB_STATE_FW_INCOMPLETE = CXGB4_DCB_INPUT_FW_INCOMPLETE = 2 > CXGB4_DCB_STATE_FW_ALLSYNCED = CXGB4_DCB_INPUT_FW_ALLSYNCED = 3 > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Applied to net-next.
|  |