Messages in this thread |  | | From | Zong Li <> | Date | Wed, 3 Oct 2018 11:26:43 +0800 | Subject | Re: [PATCH v3 5/5] RISC-V: Avoid corrupting the upper 32-bit of phys_addr_t in ioremap |
| |
Christoph Hellwig <hch@infradead.org> 於 2018年10月2日 週二 下午10:51寫道: > > On Tue, Oct 02, 2018 at 04:52:31PM +0800, Zong Li wrote: > > From: Vincent Chen <vincentc@andestech.com> > > > > For 32bit, the upper 32-bit of phys_addr_t will be flushed to zero > > after AND with PAGE_MASK because the data type of PAGE_MASK is > > unsigned long. To fix this problem, the page alignment is done by > > subtracting the page offset instead of AND with PAGE_MASK. > > > > Signed-off-by: Vincent Chen <vincentc@andestech.com> > > Looks good, > > Reviewed-by: Christoph Hellwig <hch@lst.de> > > (and I'm pretty sure I reviewed this before..)
Hi Christoph,
Very sorry about that. I didn't notice I lose these review tags. Could you please help to review again in version 4 patches? Thank you.
Regards, Zong
|  |