Messages in this thread |  | | Date | Tue, 2 Oct 2018 07:51:16 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH v3 5/5] RISC-V: Avoid corrupting the upper 32-bit of phys_addr_t in ioremap |
| |
On Tue, Oct 02, 2018 at 04:52:31PM +0800, Zong Li wrote: > From: Vincent Chen <vincentc@andestech.com> > > For 32bit, the upper 32-bit of phys_addr_t will be flushed to zero > after AND with PAGE_MASK because the data type of PAGE_MASK is > unsigned long. To fix this problem, the page alignment is done by > subtracting the page offset instead of AND with PAGE_MASK. > > Signed-off-by: Vincent Chen <vincentc@andestech.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
(and I'm pretty sure I reviewed this before..)
|  |