lkml.org 
[lkml]   [2018]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC 1/1] drivers: pinctrl: qcom: add wakeup capability to GPIO
Hi folks,

On Wed, Oct 10 2018 at 18:30 -0600, Lina Iyer wrote:
>QCOM SoC's that have Power Domain Controller (PDC) chip in the always-on
>domain can wakeup the SoC, when interrupts and GPIOs are routed to its
>interrupt controller. Only select GPIOs that are deemed wakeup capable
>are routed to specific PDC pins. During low power state, the pinmux
>interrupt controller may be non-functional but the PDC would be. The PDC
>can detect the wakeup GPIO is triggered and bring the TLMM to an
>operational state.
>
>Interrupts that are level triggered will be detected at the TLMM when
>the controller becomes operational. Edge interrupts however need to be
>replayed again.
>
>Request the corresponding PDC IRQ, when the GPIO is requested as an IRQ,
>but keep it disabled. During suspend, we can enable the PDC IRQ instead
>of the GPIO IRQ, which may or not be detected.
>
>Signed-off-by: Lina Iyer <ilina@codeaurora.org>
>---
>Changes in v4:
> - Redesign to use PDC interrupts instead of TLMM interrupt
>Changes in v3:
> - free action->name
>Changes in v2:
> - Remove IRQF_NO_SUSPEND and IRQF_ONE_SHOT from PDC IRQ
>Changes in v1:
> - Trigger GPIO in h/w from PDC IRQ handler
> - Avoid big tables for GPIO-PDC map, pick from DT instead
> - Use handler_data
>---
> drivers/pinctrl/qcom/pinctrl-msm.c | 91 +++++++++++++++++++++++++++++-
> 1 file changed, 90 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
>index 5d72ffad32c2..70b9178eba30 100644
>--- a/drivers/pinctrl/qcom/pinctrl-msm.c
>+++ b/drivers/pinctrl/qcom/pinctrl-msm.c
>@@ -719,6 +719,12 @@ static int msm_gpio_irq_set_type(struct irq_data *d, unsigned int type)
> const struct msm_pingroup *g;
> unsigned long flags;
> u32 val;
>+ struct irq_data *pdc_irqd = irq_get_handler_data(d->irq);
>+
>+ if (pdc_irqd) {
>+ irq_set_irq_type(pdc_irqd->irq, type);
>+ goto handler;
>+ }
>
> g = &pctrl->soc->groups[d->hwirq];
>
>@@ -798,6 +804,7 @@ static int msm_gpio_irq_set_type(struct irq_data *d, unsigned int type)
>
> raw_spin_unlock_irqrestore(&pctrl->lock, flags);
>
>+handler:
> if (type & (IRQ_TYPE_LEVEL_LOW | IRQ_TYPE_LEVEL_HIGH))
> irq_set_handler_locked(d, handle_level_irq);
> else if (type & (IRQ_TYPE_EDGE_FALLING | IRQ_TYPE_EDGE_RISING))
>@@ -811,9 +818,13 @@ static int msm_gpio_irq_set_wake(struct irq_data *d, unsigned int on)
> struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
> struct msm_pinctrl *pctrl = gpiochip_get_data(gc);
> unsigned long flags;
>+ struct irq_data *pdc_irqd = irq_get_handler_data(d->irq);
>
> raw_spin_lock_irqsave(&pctrl->lock, flags);
>
>+ if (pdc_irqd)
>+ irq_set_irq_wake(pdc_irqd->irq, on);
>+
> irq_set_irq_wake(pctrl->irq, on);
>
> raw_spin_unlock_irqrestore(&pctrl->lock, flags);
>@@ -895,6 +906,83 @@ static bool msm_gpio_needs_valid_mask(struct msm_pinctrl *pctrl)
> return device_property_read_u16_array(pctrl->dev, "gpios", NULL, 0) > 0;
> }
>
>+static irqreturn_t wake_irq_gpio_handler(int irq, void *data)
>+{
>+ struct irq_data *irqd = data;
>+ struct irq_desc *desc = irq_to_desc(irqd->irq);
>+
>+ desc->handle_irq(desc);
Do we see any problem calling handle_irq()?

Thanks,
Lina
>+
>+ return IRQ_HANDLED;
>+}
>+
>+static int msm_gpio_pdc_pin_request(struct irq_data *d)
>+{
>+ struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
>+ struct msm_pinctrl *pctrl = gpiochip_get_data(gc);
>+ struct platform_device *pdev = to_platform_device(pctrl->dev);
>+ const char *pin_name;
>+ int irq;
>+ int ret;
>+
>+ pin_name = kasprintf(GFP_KERNEL, "gpio%lu", d->hwirq);
>+ if (!pin_name)
>+ return -ENOMEM;
>+
>+ irq = platform_get_irq_byname(pdev, pin_name);
>+ if (irq < 0) {
>+ kfree(pin_name);
>+ return 0;
>+ }
>+
>+ ret = request_irq(irq, wake_irq_gpio_handler, irqd_get_trigger_type(d),
>+ pin_name, d);
>+ if (ret) {
>+ pr_warn("Error requesting PDC interrupt %d for %s\n",
>+ irq, pin_name);
>+ kfree(pin_name);
>+ return ret;
>+ }
>+ irq_set_handler_data(d->irq, irq_get_irq_data(irq));
>+
>+ return 0;
>+}
>+
>+static int msm_gpio_pdc_pin_release(struct irq_data *d)
>+{
>+ struct irq_data *pdc_irqd = irq_get_handler_data(d->irq);
>+ const void *name;
>+
>+ if (pdc_irqd) {
>+ irq_set_handler_data(d->irq, NULL);
>+ name = free_irq(pdc_irqd->irq, d);
>+ kfree(name);
>+ }
>+
>+ return 0;
>+}
>+
>+static int msm_gpio_irq_reqres(struct irq_data *d)
>+{
>+ struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
>+
>+ if (gpiochip_lock_as_irq(gc, irqd_to_hwirq(d))) {
>+ dev_err(gc->parent, "unable to lock HW IRQ %lu for IRQ\n",
>+ irqd_to_hwirq(d));
>+ return -EINVAL;
>+ }
>+
>+ return msm_gpio_pdc_pin_request(d);
>+}
>+
>+static void msm_gpio_irq_relres(struct irq_data *d)
>+{
>+ struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
>+
>+ msm_gpio_pdc_pin_release(d);
>+ gpiochip_unlock_as_irq(gc, irqd_to_hwirq(d));
>+}
>+
> static int msm_gpio_init(struct msm_pinctrl *pctrl)
> {
> struct gpio_chip *chip;
>@@ -919,6 +1007,8 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl)
> pctrl->irq_chip.irq_ack = msm_gpio_irq_ack;
> pctrl->irq_chip.irq_set_type = msm_gpio_irq_set_type;
> pctrl->irq_chip.irq_set_wake = msm_gpio_irq_set_wake;
>+ pctrl->irq_chip.irq_request_resources = msm_gpio_irq_reqres;
>+ pctrl->irq_chip.irq_release_resources = msm_gpio_irq_relres;
>
> ret = gpiochip_add_data(&pctrl->chip, pctrl);
> if (ret) {
>@@ -1072,4 +1162,3 @@ int msm_pinctrl_remove(struct platform_device *pdev)
> return 0;
> }
> EXPORT_SYMBOL(msm_pinctrl_remove);
>-
>--
>The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
>a Linux Foundation Collaborative Project
>

\
 
 \ /
  Last update: 2018-10-19 17:32    [W:0.128 / U:2.780 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site