lkml.org 
[lkml]   [2018]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: -Wswitch Clang warnings in drivers/scsi
From
Date
On 10/18/18 11:51 PM, Nathan Chancellor wrote:
> On Mon, Oct 08, 2018 at 11:47:09AM -0700, Bart Van Assche wrote:
>> From the user space header <sys/ioctl.h>:
>>
>> extern int ioctl (int __fd, unsigned long int __request, ...) __THROW;
>>
>> From the kernel header <linux/fs.h>:
>>
>> long (*unlocked_ioctl) (struct file *, unsigned int, unsigned long);
>> long (*compat_ioctl) (struct file *, unsigned int, unsigned long);
>>
>> Why has the second argument been declared as "unsigned long" in the glibc
>> headers and as "unsigned int" in the kernel headers? That's not clear to me.
>>
>> Bart.
>>
>
> Hi Bart,
>
> Sorry it took me so long to reply, somehow this email got lost in my
> inbox...
>
> Unfortuntely, I am unsure why there is that discrepency between the
> headers. I tried to do some research but I didn't come up with much.
>
> However, I did test changing the type of ioctl/compat_ioctl's cmd
> parameter to 'unsigned int' and came up with the following diff (rather
> large so sharing via a gist instead of pasting here):
>
> https://gist.github.com/nathanchance/8febc92735f4228574cb0464520f0f6f
>
> I'll obviously draft up a proper commit message before formally sending
> but I can address any major concerns before that happens. I checked
> every single ioctl for a negative value and there aren't any so I think
> this change makes sense to fix this warning.

Hi Nathan,

Since that change makes the SCSI code more consistent with the rest of
the Linux kernel, I'm in favor of making that change.

Bart.

\
 
 \ /
  Last update: 2018-10-19 15:57    [W:0.041 / U:0.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site