[lkml]   [2018]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 4/8] PCI: consolidate PCI config entry in drivers/pci
On Wed, Oct 17, 2018 at 5:04 PM Christoph Hellwig <> wrote:
> There is no good reason to duplicate the PCI menu in every architecture.
> Instead provide a selectable HAS_PCI symbol that indicates availability


> of PCI support and the handle the rest in drivers/pci.
> Note that for powerpc we now select HAVE_PCI globally instead of the
> convoluted mess of conditional or or non-conditional support per board,
> similar to what we do e.g. on x86. For alpha PCI is selected for the
> non-jensen configs as it was the default before, and a lot of code does
> not compile without PCI enabled. On other architectures with limited
> PCI support that wasn't as complicated I've left the selection as-is.
> Signed-off-by: Christoph Hellwig <>
> Acked-by: Thomas Gleixner <>
> Acked-by: Bjorn Helgaas <>

Just in case, could you double-check these?

Previously, architecture without "source drivers/pci/Kconfig"
could not enable PCI_ENDPOINT.

Now, any architecture can enable it
regardless of its actual PCI availability
because PCI_ENDPOINT is only guarded by HAS_DMA.

We could add 'depends on HAVE_PCI' or something
to guard it to avoid changing the logic.

bool "PCI Endpoint Support"
depends on HAVE_PCI # Is this correct ??
depends on HAS_DMA

or better to have 'depends on PCI' ?

PCI ML is also CC'ed, so comments are appreciated.

Best Regards
Masahiro Yamada

 \ /
  Last update: 2018-10-19 07:07    [W:0.135 / U:3.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site