lkml.org 
[lkml]   [2018]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] isdn: hfc_{pci,sx}: Avoid empty body if statements
From
From: Nathan Chancellor <natechancellor@gmail.com>
Date: Thu, 18 Oct 2018 17:21:17 -0700

> Thanks for the review, I went ahead and compiled with the following diff
> on top of v2 and got no warnings from Clang, GCC, or sparse, does this
> seem satisfactory for v3?

Well, one thing I notice.

> @@ -86,7 +86,7 @@ release_io_hfcpci(struct IsdnCardState *cs)
> pci_free_consistent(cs->hw.hfcpci.dev, 0x8000,
> cs->hw.hfcpci.fifos, cs->hw.hfcpci.dma);
> cs->hw.hfcpci.fifos = NULL;
> - iounmap((void *)cs->hw.hfcpci.pci_io);
> + iounmap(cs->hw.hfcpci.pci_io);
> }

Driver uses iounmap().

> @@ -1692,7 +1692,7 @@ setup_hfcpci(struct IsdnCard *card)
> printk(KERN_WARNING "HFC-PCI: No IRQ for PCI card found\n");
> return (0);
> }
> - cs->hw.hfcpci.pci_io = (char *)(unsigned long)dev_hfcpci->resource[1].start;
> + cs->hw.hfcpci.pci_io = (void __iomem *)(unsigned long)dev_hfcpci->resource[1].start;
> printk(KERN_INFO "HiSax: HFC-PCI card manufacturer: %s card name: %s\n", id_list[i].vendor_name, id_list[i].card_name);

But does not use iomap(). You won't need any cast here if it did use
iomap() properly.

Thanks.

\
 
 \ /
  Last update: 2018-10-19 02:25    [W:0.058 / U:2.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site