lkml.org 
[lkml]   [2018]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: netconsole warning in 4.19.0-rc7
On Tue, Oct 16, 2018 at 8:50 PM Dave Jones <davej@codemonkey.org.uk> wrote:
>
> On Tue, Oct 16, 2018 at 11:40:47PM -0400, Dave Jones wrote:
>
> > > This is exactly what I mentioned in my review here:
> > > https://marc.info/?l=linux-netdev&m=153816136624679&w=2
> > >
> > > "But irq is disabled here, so not sure if rcu_read_lock_bh()
> > > could cause trouble... "
> >
> > Not sure why this didn't show up for me when I was developing that
> > patch, but I can now reproduce this. The patch below fixes it for
> > me, but I'm not sure if there are still any side-effects.
> > There's also a missed unlock in the error path.
>
> I took another look at that error path. Turns out this is all we need I
> think..

Double check if rcu_dereference_bh() is happy with it.

Don't trust me, enable the relevant Kconfig and trust your test. ;)

\
 
 \ /
  Last update: 2018-10-17 07:17    [W:0.087 / U:4.928 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site