[lkml]   [2018]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v3 07/15] platform: goldfish: pipe: Return status from "deinit" since "remove" does not do much
On Mon, Oct 15, 2018 at 03:04:47PM -0700, Roman Kiryanov wrote:
> > This function can not fail, why are you returning 0 always? That
> > doesn't make sense.
> remove in struct platform_driver requires returning something, we have
> to have "return" somewhere.

But this code always returns 0, you are changing the function return
value to int, but it can not fail. I do not understand the need for
this change at all, sorry.

> I think we want to return closer to the place where we do something useful.

I do not understand this.

greg k-h

 \ /
  Last update: 2018-10-16 08:31    [W:0.058 / U:4.868 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site