[lkml]   [2018]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v3 09/15] platform: goldfish: pipe: Move goldfish_pipe to goldfish_pipe_v2
On Wed, Oct 03, 2018 at 10:17:14AM -0700, wrote:
> From: Roman Kiryanov <>
> This is the v2 driver. v1 will be added later.

This does not make any sense. Why are you renaming a driver that has
been in the tree already? It's not "v2", it is what we have today.

If you want to add a new driver later, great, but don't change the name
of an existing driver for no good reason. Userspace has a tendancy to
break when that happens.


greg k-h

 \ /
  Last update: 2018-10-15 20:38    [W:0.165 / U:5.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site