lkml.org 
[lkml]   [2018]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] dt-bindings: Add Broadcom STB OHCI, EHCI and XHCI binding document
On Wed, Sep 26, 2018 at 06:20:10PM -0400, Al Cooper wrote:
> Add DT bindings document for Broadcom STB USB OHCI, EHCI and
> XHCI drivers.
>
> Signed-off-by: Al Cooper <alcooperx@gmail.com>
> ---
> .../devicetree/bindings/usb/brcm,ehci-brcm.txt | 22 +++++++++++++++++++++
> .../devicetree/bindings/usb/brcm,ohci-brcm.txt | 22 +++++++++++++++++++++
> .../devicetree/bindings/usb/brcm,xhci-brcm.txt | 23 ++++++++++++++++++++++
> 3 files changed, 67 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/brcm,ehci-brcm.txt
> create mode 100644 Documentation/devicetree/bindings/usb/brcm,ohci-brcm.txt
> create mode 100644 Documentation/devicetree/bindings/usb/brcm,xhci-brcm.txt
>
> diff --git a/Documentation/devicetree/bindings/usb/brcm,ehci-brcm.txt b/Documentation/devicetree/bindings/usb/brcm,ehci-brcm.txt
> new file mode 100644
> index 000000000000..020b5ec40f5b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/brcm,ehci-brcm.txt
> @@ -0,0 +1,22 @@
> +Broadcom STB USB EHCI controller
> +
> +Required properties:
> +- compatible: should be "brcm,ehci-brcm-v2"

Needs an SoC specific compatible string.

> +- reg: should contain one register range i.e. start and length
> +- interrupts: description of the interrupt line
> +- phys: phandle + phy specifier pair
> + The specifier should be 0 for the OHCI/EHCI PHY and 1 for the XHCI PHY

0 or 1 depends on the phy binding. This binding just needs to say how
many phy specifiers there are.

> +
> +Optional properties:
> +- clocks: A list of phandles for the clocks

Need to say how many and the order.

> +
> +Example:
> +
> +ehci@f0b00300 {
> + compatible = "brcm,ehci-brcm-v2";
> + reg = <0xf0b00300 0xa8>;
> + interrupts = <0x0 0x5a 0x0>;
> + interrupt-names = "usb0_ehci_0";
> + phys = <&usbphy_0 0x0>;
> + clocks = <&usb20>
> +};

Similar comments in the other 2 files.

\
 
 \ /
  Last update: 2018-10-15 20:23    [W:0.098 / U:0.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site