lkml.org 
[lkml]   [2018]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 1/2] Bluetooth: Add device_get_bd_address()
From
Date
Hi Matthias,

>>>> void bt_sock_reclassify_lock(struct sock *sk, int proto);
>>>>
>>>> +int device_get_bd_address(struct device *dev, bdaddr_t *bd_addr);
>>>
>>> Maybe change the API name to start with bt_ and get rid of device_?
>>
>> device_ indicates that we get the BD_ADDR for a 'struct device' and
>> not for e.g. a 'struct fwnode_handle'.
>>
>> Anyway with this version of the patch fwnode_get_bd_address() has been
>> scrapped and it might never be introduced again, so I'm open to change
>> the name to bt_ if there is a general preference for it.
>
> Marcel, can you live with this being added to the Bluetooth code base
> instead of property? Also if you'd prefer the function to be named
> bt_get_bd_address() let me know.

explain to me again why this is useful? I am failing to see the benefit if this is not part of the property.h API.

Regards

Marcel

\
 
 \ /
  Last update: 2018-10-15 20:06    [W:0.066 / U:11.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site