[lkml]   [2018]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[PATCH 0/5] Do not touch pages/zones during hot-remove path
From: Oscar Salvador <>

This patchset aims to solve [1] and [2] issues.
Due to the lack of feedback of previous versions, I decided to go safe,
so I reverted some of the changes I did in RFCv3:

1) It is no longer based on [3], although the code would be easier and
the changes less.

2) hotplug lock stays in HMM/devm, mainly because I am not sure whether
it is ok to leave the kasan calls out of lock or not.
If we think that this can be done, the hotplug lock can be moved
within add/del_device_memory, which would be nicer IMHO.

3) Although I think that init_currently_empty_zone should be protected
by the spanlock since it touches zone_start_pfn, I decided to leave
it as it is right now.
The main point of moving it within the lock was to be able to move
move_pfn_range_to_zone out of the hotplug lock for HMM/devm code.

The main point of this patchset is to move all the page/zone handling
from the hot-remove path, back to the offlining stage.
In this way, we can better split up what each part does:

* hot-add path:
- Create a new resource for the hot-added memory
- Create memory sections for the hot-added memory
- Create the memblocks representing the hot-added memory

* online path:
- Re-adjust zone/pgdat nr of pages (managed, spanned, present)
- Initialize the pages from the new memory-range
- Online memory sections

* offline path:
- Offline memory sections
- Re-adjust zone/pgdat nr of pages (managed, spanned, present)

* hot-remove path:
- Remove memory sections
- Remove memblocks
- Remove resources

So, hot-add/remove stages should only care about sections and memblocks.
While all the zone/page handling should belong to the online/offline stage.

Another thing is that for the sake of reviewability, I split the patchset
in 5 parts, but pathc3 could be combined into patch4.

This patchset is based on top of mmotm.


Oscar Salvador (5):
mm/memory_hotplug: Add nid parameter to arch_remove_memory
mm/memory_hotplug: Create add/del_device_memory functions
mm/memory_hotplug: Check for IORESOURCE_SYSRAM in
mm/memory_hotplug: Move zone/pages handling to offline stage
mm/memory-hotplug: Rework unregister_mem_sect_under_nodes

arch/ia64/mm/init.c | 6 +-
arch/powerpc/mm/mem.c | 14 +---
arch/s390/mm/init.c | 2 +-
arch/sh/mm/init.c | 6 +-
arch/x86/mm/init_32.c | 6 +-
arch/x86/mm/init_64.c | 11 +---
drivers/base/memory.c | 9 ++-
drivers/base/node.c | 38 ++---------
include/linux/memory.h | 2 +-
include/linux/memory_hotplug.h | 21 ++++--
include/linux/node.h | 9 ++-
kernel/memremap.c | 13 ++--
kernel/resource.c | 16 +++++
mm/hmm.c | 35 +++++-----
mm/memory_hotplug.c | 142 +++++++++++++++++++++++++----------------
mm/sparse.c | 6 +-
16 files changed, 177 insertions(+), 159 deletions(-)


 \ /
  Last update: 2018-10-15 17:31    [W:0.232 / U:0.824 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site