[lkml]   [2018]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v3 06/24] powerpc/mm: properly set PAGE_KERNEL flags in ioremap()
LEROY Christophe <> writes:
> Michael Ellerman <> a écrit :
>> Michael Ellerman <> writes:
>>> Christophe Leroy <> writes:
>>>> Set PAGE_KERNEL directly in the caller and do not rely on a
>>>> hack adding PAGE_KERNEL flags when _PAGE_PRESENT is not set.
>>>> As already done for PPC64, use pgprot_cache() helpers instead of
>>>> _PAGE_XXX flags in PPC32 ioremap() derived functions.
>>>> Signed-off-by: Christophe Leroy <>
>>> Something in here is breaking my p5020ds (both 32-bit and 64-bit):
>> Oh duh.
>> That's because I didn't take patch 4.
>> It didn't have any acks, but I guess I'll just merge it rather than
>> breaking things.
> Yes indeed. Maybe should I have followed it more carrefully to ensure
> it gets an ack.

That's OK, I should have paid more attention to what it was actually
doing, I thought it was just a cleanup.


 \ /
  Last update: 2018-10-15 11:26    [W:0.064 / U:2.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site