lkml.org 
[lkml]   [2018]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 7/8] eisa: consolidate EISA Kconfig entry in drivers/eisa
On Sun, Oct 14, 2018 at 12:11 AM Christoph Hellwig <hch@lst.de> wrote:
>
> Let architectures opt into EISA support by selecting HAS_EISA and
> handle everything else in drivers/eisa.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---


How about HAVE_EISA ?


You forgot to add
source "drivers/eisa/Kconfig" to drivers/Kconfig


You forgot to delete the one
from arch/alpha/Kconfig


> arch/alpha/Kconfig | 8 +++-----
> arch/arm/Kconfig | 16 +---------------
> arch/mips/Kconfig | 31 +++++--------------------------
> arch/powerpc/Kconfig | 3 ---
> arch/x86/Kconfig | 19 +------------------
> drivers/eisa/Kconfig | 21 ++++++++++++++++++++-
> drivers/parisc/Kconfig | 11 +----------
> 7 files changed, 31 insertions(+), 78 deletions(-)
>
> diff --git a/arch/alpha/Kconfig b/arch/alpha/Kconfig
> index 73a7558c71bd..6a9be9cb74e6 100644
> --- a/arch/alpha/Kconfig
> +++ b/arch/alpha/Kconfig
> @@ -6,6 +6,9 @@ config ALPHA
> select ARCH_MIGHT_HAVE_PC_SERIO
> select ARCH_NO_PREEMPT
> select ARCH_USE_CMPXCHG_LOCKREF
> + select HAS_EISA if ALPHA_GENERIC || ALPHA_JENSEN || ALPHA_ALCOR || \
> + ALPHA_MIKASA || ALPHA_SABLE || ALPHA_LYNX || \
> + ALPHA_NORITAKE || ALPHA_RAWHIDE
> select HAS_PCI if !ALPHA_JENSEN
> select PCI if !ALPHA_JENSEN
> select HAVE_AOUT
> @@ -518,11 +521,6 @@ config ALPHA_SRM
>
> If unsure, say N.
>
> -config EISA
> - bool
> - depends on ALPHA_GENERIC || ALPHA_JENSEN || ALPHA_ALCOR || ALPHA_MIKASA || ALPHA_SABLE || ALPHA_LYNX || ALPHA_NORITAKE || ALPHA_RAWHIDE
> - default y
> -


Better to add CONFIG_EISA=y to arch/alpha/defconfig
to not flip the default?



--
Best Regards
Masahiro Yamada

\
 
 \ /
  Last update: 2018-10-15 08:39    [W:0.164 / U:2.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site