[lkml]   [2018]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v3 2/2] mmc: tmio: remove TMIO_MMC_HAVE_HIGH_REG flag
On Wed, Oct 10, 2018 at 12:51:32PM +0900, Masahiro Yamada wrote:
> TMIO_MMC_HAVE_HIGH_REG is confusing due to its counter-intuitive name.
> All the TMIO MMC variants (TMIO MMC, Renesas SDHI, UniPhier SD) actually
> have high registers. It is just that each of them implements its own
> registers there. The original IP from Panasonic only defines registers
> 0x00-0xff in the bus_shift=1 review. The register area above them is
> platform-dependent.
> In fact, TMIO_MMC_HAVE_HIGH_REG is set only by tmio-mmc.c and used to
> test the accessibility of CTL_SDIO_REGS. Because it is specific to
> the TMIO MFD variant, the right thing to do is to move such registers
> to tmio_mmc.c and delete the TMIO_MMC_HAVE_HIGH_REG flag.
> Signed-off-by: Masahiro Yamada <>

Reviewed-by: Wolfram Sang <>

[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2018-10-15 00:29    [W:0.073 / U:2.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site