lkml.org 
[lkml]   [2018]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v4 3/6] parisc: add system call table generation support
Date
Firoz Khan wrote:
> Hi Rolf,
>
> On Fri, 12 Oct 2018 at 17:37, Rolf Eike Beer <eike-kernel@sf-tec.de> wrote:
> > Firoz Khan wrote:

> > > +prefix="$4"
> > > +offset="$5"
> > > +
> > > +fileguard=_UAPI_ASM_PARISC_`basename "$out" | sed \
> > > + -e 'y/abcdefghijklmnopqrstuvwxyz/ABCDEFGHIJKLMNOPQRSTUVWXYZ/' \
> > > + -e 's/[^A-Z0-9_]/_/g' -e 's/__/_/g'`
> > > +grep -E "^[0-9A-Fa-fXx]+[[:space:]]+${my_abis}" "$in" | sort -n | (
> > > + echo "#ifndef ${fileguard}"
> > > + echo "#define ${fileguard}"
> > > + echo ""
> > > +
> > > + nxt=0
> > > + while read nr abi name entry compat ; do
> > > + if [ -z "$offset" ]; then
> > > + echo -e "#define __NR_${prefix}${name}\t$nr"
> >
> > This mixed indentation with both tabs and spaces is a bit messy.
>
> Is this what you suggested?
> - echo -e "#define __NR_${prefix}${name}\t$nr"
> + echo "#define __NR_${prefix}${name} $nr"

No, this was actually only about the script itself. Looks like your editor has
tab-width 8 and indentation 4 or so.

Eike[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-10-15 07:18    [W:0.143 / U:13.980 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site