lkml.org 
[lkml]   [2018]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] KEYS: trusted: fix -Wvarags warning
From
Date
Hi James,

>> From the links provided in the patch it seems that one cannot pass
>> char/float/short to va_start(). Fair enough. So if we make h3 an
>> unsigned int, the issue goes away, no?
>
> For the current version of clang, yes. However, if we're fixing this
> for good a char * pointer is the only guaranteed thing because it
> mirrors current use in printf.
>

All right. I guess I wasn't aware that non-printf like variadic
functions are now considered harmful or of the impending crusade against
them :)

But in the context of this patch, can we please use something less
invasive than changing all the arguments around? Promoting h3 to a bool
(if possible) or int/unsigned int would get my vote.

Regards,
-Denis

\
 
 \ /
  Last update: 2018-10-12 17:54    [W:0.095 / U:2.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site