[lkml]   [2018]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] KEYS: trusted: fix -Wvarags warning
On Fri, 2018-10-12 at 10:44 -0500, Denis Kenzior wrote:
> Hi James,
> > > So instead of having unsigned char h3, can't we simply have bool
> > > h3 or unsigned int h3?
> >
> > Given the ambiguity in the standards, the safe thing that will work
> > for all time and all potential compilers is a char *
> >
> All right. You state this with certainty, but I'd still like you to
> educate me why?
> From the links provided in the patch it seems that one cannot pass
> char/float/short to va_start(). Fair enough. So if we make h3 an
> unsigned int, the issue goes away, no?

For the current version of clang, yes. However, if we're fixing this
for good a char * pointer is the only guaranteed thing because it
mirrors current use in printf.


 \ /
  Last update: 2018-10-12 17:46    [W:0.050 / U:1.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site