lkml.org 
[lkml]   [2018]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3] ARM: dts: imx6sx-sdb: Fix enet phy regulator
Date
On Tue, 2018-10-09 at 09:09 +0800, Shawn Guo wrote:
> On Mon, Oct 08, 2018 at 03:28:01PM +0000, Leonard Crestez wrote:
> > Bindings for "fixed-regulator" only explicitly support "gpio" property,
> > not "gpios". Fix by correcting the property name.
> >
> > The enet PHYs on imx6sx-sdb needs to be explicitly reset after a power
> > cycle, this can be handled by the phy-reset-gpios property. Sadly this
> > is not handled on suspend: the fec driver turns phy-supply off but
> > doesn't assert phy-reset-gpios again on resume.
> >
> > Since additional phy-level work is required to support powering off the
> > phy in suspend fix the problem by just marking the regulator as
> > "boot-on" "always-on" so that it's never turned off. This behavior is
> > equivalent to older releases.
> >
> > Keep the phy-reset-gpios property on fec anyway because it is a correct
> > description of board design.
> >
> > This issue was exposed by commit efdfeb079cc3 ("regulator: fixed:
> > Convert to use GPIO descriptor only") which causes the "gpios" property
> > to also be parsed. Before that commit the "gpios" property had no
> > effect, PHY reset was only handled in the the bootloader.

> So this is a fix we only need to apply for 4.20-rc, right?

Yes.

This issue was exposed by gpio changes for 4.20 but 4.19 RCs are fine.

--
Regards,
Leonard
\
 
 \ /
  Last update: 2018-10-10 01:00    [W:0.239 / U:1.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site