lkml.org 
[lkml]   [2018]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH net v2] r8169: always autoneg on resume
Date
Quoting Daan Wendelen (2018-09-30 22:17:51)
> Hi Alex,
>
> I randomly opened your patch even though I have absolutely no idea what this patch is about, but I
> found a mistake in one of the comments:
>
> On Sun, Sep 30, 2018 at 11:06:39AM -0400, Alex Xu (Hello71) wrote:
> > This affects at least versions 25 and 33, so assume all cards are broken
> ...
> > * 1GBit link after resuming from S3. For whatever reason the PHY on
> > - * this chip doesn't properly start a renegotiation when soft-reset.
> > + * these chips doesn't properly start a renegotiation when soft-reset.
> ~~~~~~~
> I believe it should be "these chips don't"
>
> With kind regards,
> Daan

The grammar is correct as is. The subject of the sentence is "the PHY",
which is singular. However, I think it should be "the PHYs" instead,
assuming that they are different.

\
 
 \ /
  Last update: 2018-10-01 00:31    [W:0.055 / U:3.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site