lkml.org 
[lkml]   [2018]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/8] x86/feature: Detect the x86 IBRS feature to control Speculation
From
Date
On 09/01/2018 18:53, Tim Chen wrote:
> On 01/09/2018 02:39 AM, Paolo Bonzini wrote:
>
>> +
>> +#define MSR_IA32_SPEC_CTRL 0x00000048
>> +#define SPEC_CTRL_FEATURE_DISABLE_IBRS (0 << 0)
>> +#define SPEC_CTRL_FEATURE_ENABLE_IBRS (1 << 0)
>
>
> Boris requested that the name for ENABLE/DISABLE to be shortened to
> SPEC_CTRL_{ENABLE,DISABLE}_IBRS. I'm planning to do that
> for the next patchset update.

Were you also planning to include KVM patches in your patchset sooner or
later? Or would that be a separate submission?

(Either is fine; in the latter case, I assume I'll get a topic branch
from the tip tree).

>> +
>> +#define MSR_IA32_PRED_CMD 0x00000049
>> +#define PRED_CMD_IBPB (1UL << 0)
>> +
>
> The IBPB stuff should be enumerated separately.
> Feel free to create a separate patch for this chunk.

I think it makes sense for the patch that adds the CPU feature to also
change msr-index.h.

Paolo

\
 
 \ /
  Last update: 2018-01-14 23:19    [W:0.081 / U:5.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site