lkml.org 
[lkml]   [2018]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 12/12] perf report: Add --task option to display monitored tasks
On Tue, Jan 09, 2018 at 10:56:07AM +0900, Namhyung Kim wrote:

SNIP

> > +static struct task *task_list(struct task *task, struct machine *machine)
> > +{
> > + struct thread *parent_thread, *thread = task->thread;
> > + struct task *parent_task;
> > +
> > + /* Already listed. */
> > + if (!list_empty(&task->list))
> > + return NULL;
> > +
> > + /* Last one in the chain. */
> > + if (thread->ppid == -1)
> > + return task;
> > +
> > + parent_thread = machine__findnew_thread(machine, -1, thread->ppid);
>
> I think it should be machine__find_thread() since creating a new
> thread at this stage would lack thread->priv anyway.

ugh, that's right.. I tried to stay safe, but the NULL
in priv would bring it down anyway

Arnaldo,
I already see changed version on top of your branch,
please let me know if you make also this change or
I should send v2

thanks,
jirka

\
 
 \ /
  Last update: 2018-01-14 23:18    [W:0.069 / U:1.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site