lkml.org 
[lkml]   [2018]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 03/15] staging: lustre: replace simple cases of LIBCFS_ALLOC with kzalloc.
On Mon, Jan 08 2018, Greg Kroah-Hartman wrote:

> On Mon, Dec 18, 2017 at 11:46:30AM +1100, NeilBrown wrote:
>> All usages of the form
>> LIBCFS_ALLOC(variable, sizeof(variable))
>> or
>> LIBCFS_ALLOC(variable, sizeof(variable's-type))
>>
>> are changed to
>> variable = kzalloc(sizeof(...), GFP_NOFS);
>>
>> Similarly, all
>> LIBCFS_FREE(variable, sizeof(variable))
>> become
>> kfree(variable);
>>
>> None of these need the vmalloc option, or any of the other minor
>> benefits of LIBCFS_ALLOC().
>>
>> Signed-off-by: NeilBrown <neilb@suse.com>
>
> As this broke the kbuild system, I'll stop here in this patch series.
> Can you please fix it up, rebase and resend the remaining ones in this
> series?

Hi Greg,
thanks for applying the patches.

That patch had a typo in code that was only included if CONFIG_INFINIBAND is
enabled, which I didn't have in my testing at the time. I hadn't
resent when I fixed it as I was waiting to see if there would be
feedback.
If the protocol is "you apply sometime after two weeks if there is no
feedback (and no breakage)", then I'll aim to work with that.

I'll resend with the rest of the kmalloc patches.

Thanks,
NeilBrown



[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-01-14 23:18    [W:1.398 / U:0.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site