Messages in this thread |  | | Date | Mon, 8 Jan 2018 18:11:22 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH 01/12] perf tools: Enable LIBBABELTRACE by default |
| |
On Mon, Jan 08, 2018 at 12:24:33PM -0300, Arnaldo Carvalho de Melo wrote:
SNIP
> > Works: > > [acme@jouet perf]$ ldd ~/bin/perf | grep babel > libbabeltrace-ctf.so.1 => /lib64/libbabeltrace-ctf.so.1 (0x00007fcb688d0000) > libbabeltrace.so.1 => /lib64/libbabeltrace.so.1 (0x00007fcb67e92000) > [acme@jouet perf]$ rpm -q libbabeltrace-devel > libbabeltrace-devel-1.5.3-1.fc27.x86_64 > [acme@jouet perf]$ > > But then, if we show: > > Auto-detecting system features: > ... dwarf: [ on ] > ... dwarf_getlocations: [ on ] > ... glibc: [ on ] > ... gtk2: [ on ] > ... libaudit: [ on ] > ... libbfd: [ on ] > ... libelf: [ on ] > ... libnuma: [ on ] > ... numa_num_possible_cpus: [ on ] > ... libperl: [ on ] > ... libpython: [ on ] > ... libslang: [ on ] > ... libcrypto: [ on ] > ... libunwind: [ on ] > ... libdw-dwarf-unwind: [ on ] > ... zlib: [ on ] > ... lzma: [ on ] > ... get_cpuid: [ on ] > ... bpf: [ on ] > > Shoudln't we tell the user that babeltrace was linked too?
the logic is just to simply display the state of features which we provide in FEATURE_DISPLAY variable, which is believed to be common and important enough to display status about
maybe we could display it with 'make VF=1' output?
jirka
|  |