[lkml]   [2018]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 04/19] staging: lustre: discard cfs_time_seconds()
On Mon, Jan 08, 2018 at 04:52:35PM +0000, James Simmons wrote:
> > cfs_time_seconds() converts a number of seconds to the
> > matching number of jiffies.
> > The standard way to do this in Linux is "* HZ".
> > So discard cfs_time_seconds() and use "* HZ" instead.
> Just to make you aware I have been working for several months on
> moving lustre away from using jiffies as much as possible. The
> problem with using HZ is that it can vary. So when you have a
> parallel file system with batches of nodes that have different
> values of HZ you can get very interesting corner cases. So I have
> been moving everything over to time64_t and ktime. Also I mostly
> have killed off the cfs_time_shift* and crap as well. You see all
> work under So many
> of the cases you did below don't event exist any more. I was
> planning to push those changes after the next merge window.

First patch to me "wins", none of this "don't touch this code because
I'm going to work on it in the future" stuff. That has been documented
to kill contributions and in one case, a whole opensource kernel

So Neil's patches should be evaluated first, don't develop behind closed
walls like you are doing.

I've merged almost all of them now, except for the ones that broke the
build :)


greg k-h

 \ /
  Last update: 2018-01-14 23:17    [W:0.052 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site