lkml.org 
[lkml]   [2018]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 10/10] x86/retpoline: Exclude objtool with retpoline
On Mon, Jan 08, 2018 at 10:34:00AM +0000, Woodhouse, David wrote:
> On Mon, 2018-01-08 at 11:25 +0100, Thomas Gleixner wrote:
> > On Sun, 7 Jan 2018, David Woodhouse wrote:
> >
> > Cc+ Josh Poimboeuf <jpoimboe@redhat.com>
> >
> > Sigh....
> >
> > > From: Andi Kleen <ak@linux.intel.com>
> > > 
> > > objtool's assembler nanny currently cannot deal with the code generated
> > > by the retpoline compiler and throws hundreds of warnings, mostly
> > > because it sees calls that don't have a symbolic target.
> > > 
> > > Exclude all the options that rely on objtool when RETPOLINE is active.
> > > 
> > > This mainly means that we use the frame pointer unwinder and livepatch
> > > is not supported.
> > > 
> > > Eventually objtool can be fixed to handle this.
>
> I believe Josh is on vacation and I've asked Amit to take a look at
> this, at least as far as ensuring that it doesn't actually disable
> kpatch.

I'm back now and will start looking at it this week.

For future revisions of the patch set, can you add me to CC? And also
it would be good to add x86@kernel.org as I'm sure the other x86
maintainers (mingo and hpa) want to see these patches.

--
Josh

\
 
 \ /
  Last update: 2018-01-14 23:17    [W:0.108 / U:0.852 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site