[lkml]   [2018]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 3/3] regcache: flat: Add valid bit to this cache type
On Sun, Jan 07, 2018 at 05:22:34PM -0600, Andrew F. Davis wrote:
> Other regmap cache types (LZO, RBtree) report back un-successful register
> lookups when a value has not been previously written into the cache. This
> allows regmap core to perform a real un-cached lookup to fetch the value.
> The Flat type cache does not and so all read succeed reporting zero for the
> registers value, even when the actual value is not known.

> We fix this by changing the flat cache element type to a struct
> containing both the register's value and a bool signifying if this value
> is an actual cached value or not. This also opens up a path to implement
> additional regcache_ops such as "sync" and "drop" that rely on such
> validity information.

The reason we don't do this for the flat cache is that its whole purpose
is to be as fast as possible in order to make it easier for MMIO devices.
Things that can take the hit of extra complexity should just use a rbtree
cache since if the registers are all bunched together it rapidly becomes
effectively the same data structure anyway. Unless you really know why
you're using a flat cache you probably shouldn't.
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2018-01-14 23:17    [W:0.110 / U:2.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site