Messages in this thread |  | | From | Andy Shevchenko <> | Date | Mon, 8 Jan 2018 01:02:09 +0200 | Subject | Re: [PATCH] zsmalloc: use U suffix for negative literals being shifted |
| |
On Sun, Jan 7, 2018 at 5:04 PM, Minchan Kim <minchan@kernel.org> wrote:
>> - link->next = -1 << OBJ_TAG_BITS; >> + link->next = -1U << OBJ_TAG_BITS; > > -1UL?
Oh, boy, shouldn't be rather GENMASK() / GENMASK_ULL() in a way how it's done, for example, here: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/commit/?h=for-next&id=d2b3c353595a855794f8b9df5b5bdbe8deb0c413
-- With Best Regards, Andy Shevchenko
|  |