lkml.org 
[lkml]   [2018]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 1/2] sysfs/cpu: Add vulnerability folder
On Sun, 7 Jan 2018, Greg Kroah-Hartman wrote:
> > drivers/base/Kconfig | 3 +++
> > drivers/base/cpu.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
> > include/linux/cpu.h | 7 +++++++
> > 3 files changed, 58 insertions(+)
>
> A Documentation/ABI/ update is needed for the new sysfs files.

Sure.

> > +#ifdef CONFIG_GENERIC_CPU_VULNERABILITIES
> > +
> > +ssize_t __weak cpu_show_meltdown(struct device *dev,
> > + struct device_attribute *attr, char *buf)
> > +{
> > + return snprintf(buf, PAGE_SIZE - 2, "Not affected\n");
>
> sysfs is one-value-per-file, so you never need to care about the page
> size, a simple sprintf() is fine. No need to change if you don't want
> to, your call.

Done.

> > +static DEVICE_ATTR(spectre_v2, 0444, cpu_show_spectre_v2, NULL);
>
> DEVICE_ATTR_RO() please.
>
> Yeah, that does make the global symbols a bit different, meltdown_show()
> and the like. Hm, I guess this is ok, given that it's ment to be
> overridden.

That and I expect that in the not so distant future we'll see write
functions as well.

> Oh, nevermind. So, just a documentation update please, that can always
> be an add-on patch if you promise to do it :)

You should never make such offers. These promises land on that growth only
thingy, aka. todo list :)

Thanks,

tglx

\
 
 \ /
  Last update: 2018-01-14 23:16    [W:0.043 / U:5.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site