lkml.org 
[lkml]   [2018]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH] staging: iio: light: Add breaks to lengthy lines
From
Date
On Sun, 2018-01-07 at 16:28 +0000, Jonathan Cameron wrote:
> On Sun, 7 Jan 2018 15:08:01 +0000
> George Edward Bulmer <gebulmer@googlemail.com> wrote:
>
> > This fixes three instances of checkpatch warning:
> > WARNING: line over 80 characters
> >
> > Signed-off-by: George Edward Bulmer <gebulmer@googlemail.com>
>
> Applied, thanks,

I believe these are examples of long line conversions
that should not be applied.

Most of the problem here is the very long identifier naming.
57 character identifiers are pretty unnecessary.

> Jonathan
> > ---
> > drivers/staging/iio/light/tsl2x7x.c | 9 ++++++---
> > 1 file changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/iio/light/tsl2x7x.c b/drivers/staging/iio/light/tsl2x7x.c
> > index 42ed9c015aaf..126e11530ce0 100644
> > --- a/drivers/staging/iio/light/tsl2x7x.c
> > +++ b/drivers/staging/iio/light/tsl2x7x.c
> > @@ -1441,7 +1441,8 @@ static irqreturn_t tsl2x7x_event_handler(int irq, void *private)
> >
> > static struct attribute *tsl2x7x_ALS_device_attrs[] = {
> > &dev_attr_in_illuminance0_calibscale_available.attr,
> > - &iio_const_attr_in_illuminance0_integration_time_available.dev_attr.attr,
> > + &iio_const_attr_in_illuminance0_integration_time_available
> > + .dev_attr.attr,
> > &dev_attr_in_illuminance0_target_input.attr,
> > &dev_attr_in_illuminance0_calibrate.attr,
> > &dev_attr_in_illuminance0_lux_table.attr,
> > @@ -1455,7 +1456,8 @@ static struct attribute *tsl2x7x_PRX_device_attrs[] = {
> >
> > static struct attribute *tsl2x7x_ALSPRX_device_attrs[] = {
> > &dev_attr_in_illuminance0_calibscale_available.attr,
> > - &iio_const_attr_in_illuminance0_integration_time_available.dev_attr.attr,
> > + &iio_const_attr_in_illuminance0_integration_time_available
> > + .dev_attr.attr,
> > &dev_attr_in_illuminance0_target_input.attr,
> > &dev_attr_in_illuminance0_calibrate.attr,
> > &dev_attr_in_illuminance0_lux_table.attr,
> > @@ -1471,7 +1473,8 @@ static struct attribute *tsl2x7x_PRX2_device_attrs[] = {
> >
> > static struct attribute *tsl2x7x_ALSPRX2_device_attrs[] = {
> > &dev_attr_in_illuminance0_calibscale_available.attr,
> > - &iio_const_attr_in_illuminance0_integration_time_available.dev_attr.attr,
> > + &iio_const_attr_in_illuminance0_integration_time_available
> > + .dev_attr.attr,
> > &dev_attr_in_illuminance0_target_input.attr,
> > &dev_attr_in_illuminance0_calibrate.attr,
> > &dev_attr_in_illuminance0_lux_table.attr,
>
>

\
 
 \ /
  Last update: 2018-01-14 23:16    [W:0.080 / U:4.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site