[lkml]   [2018]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: atm/clip: Use seq_puts() in svc_addr()
>> Is the function "seq_puts" a bit more efficient for the desired output
>> of a single string in comparison to calling the function "seq_printf"
>> for this purpose?
> Will you please be so kind and tell us?

How do you think about to get the run time characteristics for these
sequence output functions better documented?

Can an information like “WARNING: Prefer seq_puts to seq_printf”
(from the script “”) be another incentive?

>>> and "strings should be quickly put into a sequence"
>>> isn't terribly helpful.
>> Which wording would you find more appropriate for the suggested
>> adjustment of these function calls?
> Whatever describes the actual issue and what you're doing about it.
> Turn your rhetorical question above into a commit message, done.
> Compare that with your original commit message, on the other hand,
> and you should understand what I mean.

Which descriptions are you really missing for the affected data output?


 \ /
  Last update: 2018-01-14 23:16    [W:0.349 / U:1.892 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site